Split quality checks from CI test matrix#4180
Open
KRRT7 wants to merge 5 commits into
Open
Conversation
b039c86 to
3b3a021
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4180 +/- ##
=======================================
Coverage ? 94.87%
=======================================
Files ? 96
Lines ? 8384
Branches ? 0
=======================================
Hits ? 7954
Misses ? 430
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits OS/Python-independent quality checks out of the full test matrix and replaces Poetry-based dependency setup with uv-based installs.
Before, every matrix entry ran:
black --check .mypy -p rich --no-incrementalpytestwith coverageAfter this change:
qualityjob runs Black, mypy, coverage, and Codecov upload.pytest tests -vafterqualitypasses.qualityjob already covers that runtime.pyproject.tomlnow includes PEP-style dependency groups:testfor matrix jobs: pytest plus attrs.devfor quality: includestest, plus Black, mypy, pytest-cov, and typing-extensions.steps.cached-poetry-dependencies.outputs.cache-hitcondition is removed because there was no cache step defining it.Why
The previous workflow repeated format checks, type checks, coverage generation, and coverage upload across 17 matrix jobs. Those checks are not OS-specific, and coverage only needs to be uploaded once.
This keeps compatibility coverage across Windows, macOS, Ubuntu, and Python versions, while reducing repeated CI work and replacing Poetry environment setup with uv installs.
Validation
I also tested both uv dependency groups in temporary virtualenvs:
All passed locally.
Expected CI impact
quality, avoiding matrix spend when formatting/typechecking/coverage failstestdependency group instead of all dev tooling