Open
Conversation
Collaborator
Author
|
One more thing I should add:
If you don't use CI / CD - I can set up a Github action that performs this, I just need you to add your nuget API key Thanks!! Jeff |
Collaborator
Author
|
@MilleBo - I believe that I cannot approve my own PR and need your approval and review for this |
Collaborator
Author
|
@MilleBo - bump on this please <3 |
Contributor
|
Sorry for the later answer. Saw that we had three different pull requests with .NET 7 now. Guess the other two should be remoed and this one should be corrected with correct syntax ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I added net7 as a target framework. It should work fine, let me know if there are any issues with it.
Few questions for you:
1.) I saw this code here: do you also want to add a target of
.netstandard2.0?2.) How do you 'build' this and publish to nuget.org? It would be cool to add 'SourceLink' but im not sure how you publish this. Depending if you use GitHub or Azure Pipelines, the package will be different.
Let me know if there are any issues or questions!
Thanks