feat(color-picker): support input-less trigger#4306
Open
Malusnow wants to merge 2 commits into
Open
Conversation
Add the isInput prop to control whether the color value input is displayed.The prop defaults to true to preserve the existing behavior.
Malusnow
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
16 tasks
Collaborator
TDesign Component Site Preview Open
|
commit: |
Author
|
@RylanBot 您好，test没跑通似乎并不是本次修改引起的？我还需要做些什么吗 |
Collaborator
Prettier 配置有些问题，导致流水线产生了一些冲突... |
Collaborator
|
当前的 api 定义还有待商榷，之前在 Tencent/tdesign-vue-next#5383 有提过类似的改动，我先跟进下之前的 pr 确定下 api 的定义。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the isInput prop to control whether the color value input is displayed.The prop defaults to true to preserve the existing behavior.
🤔 这个 PR 的性质是？
🔗 相关 Issue
Tencent/tdesign-common#2567
💡 需求背景和解决方案
支持无文字输入框样式
新增isInput prop 相关pr：TDesignOteam/tdesign-api#911
新增无文字输入样式 相关pr：Tencent/tdesign-common#2581
本pr的工作：
ColorPicker.tsx 透传 isInput
components/trigger.tsx 添加 no-input class
通过设置
<ColorPicker defaultValue="#0052d9" isInput={false} />可实现以下效果已在本地联调，ui效果如下，其余功能可正常使用
📝 更新日志
tdesign-react
☑️ 请求合并前的自查清单