Repository navigation
feat(input): contenteditable 的圆点贴文字末尾,用与逐段按钮共用的行盒测量,多行与行内混排都对(#671) - #721
Merged
Merged
Conversation
contenteditable 有真实的文本节点,末尾取共用行盒测量(#634)里最后一个有 高度的行盒:行内混排时它是最后那段文字自己的行盒,不是外层元素的边框盒; LTR 取右边缘、RTL 取左边缘。坐标已是屏幕坐标,不另养镜像。与光标并排 (#667)、钳边(#669)、停手对齐(#670)、测不出回落(#668)都走文本框 那一套。 TC-E2E-128 的回落位置断言改为“整颗在框里”,位置真值交给 TC-E2E-141。 Co-Authored-By: zhexuancai-uts <261878103+zhexuancai-uts@users.noreply.github.com>
Co-Authored-By: zhexuancai-uts <261878103+zhexuancai-uts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
contenteditable 富文本框(包括受控编辑器)里的圆点还停在回落位置(框内侧右下角),和多行、单行文本框(贴文字末尾)不一致。
根因
圆点位置只给文本框接了镜像测量,contenteditable 直接走回落。
修复
textRects)里最后一个有高度的行盒。验证
pnpm test:115 个文件、1427 条,全部通过。pnpm typecheck通过。pnpm test:e2e:core:98 条通过,2 条跳过。Closes #671