Skip to content

Conversation

@siwelwerd
Copy link
Contributor

Addresses #898 . Converts images in PR module to Prefigure

@github-actions
Copy link

@github-actions
Copy link

🚀 Preview available 🚀

https://7e736ba6.tbil.pages.dev

@github-actions
Copy link

🚀 Preview available 🚀

https://8e3d3fdd.tbil.pages.dev

@github-actions
Copy link

🚀 Preview available 🚀

https://c2d41de8.tbil.pages.dev

@github-actions
Copy link

🚀 Preview available 🚀

https://e77033f1.tbil.pages.dev

@github-actions
Copy link

🚀 Preview available 🚀

https://71425450.tbil.pages.dev

@github-actions
Copy link

🚀 Preview available 🚀

https://e6d02e40.tbil.pages.dev

@siwelwerd siwelwerd marked this pull request as ready for review January 23, 2026 21:40
@tdegeorge
Copy link
Contributor

In [Activity 4.1.15
https://7e736ba6.tbil.pages.dev/preview/precalculus/PR1#PR1-activity-4](url), the labeling of the graphs seemed to have been cut off.

@tdegeorge
Copy link
Contributor

tdegeorge commented Feb 8, 2026

General question: do we want to provide more of an explanation of the graph? Like for for many of these answers, the speech says, "A graph of a parabola." Is the goal to say something like "a graph of a parabola that opens upward with a vertex at (x,y) and an axis of symmetry at x=#"? If so, I can put in the suggestions, but I wasn't sure what the goal is for this round of edits.

@siwelwerd
Copy link
Contributor Author

In [Activity 4.1.15 https://7e736ba6.tbil.pages.dev/preview/precalculus/PR1#PR1-activity-4](url), the labeling of the graphs seemed to have been cut off.

I believe newer Prefigure versions take care of this

@siwelwerd
Copy link
Contributor Author

General question: do we want to provide more of an explanation of the graph? Like for for many of these answers, the speech says, "A graph of a parabola." Is the goal to say something like "a graph of a parabola that opens upward with a vertex at (x,y) and an axis of symmetry at x=#"? If so, I can put in the suggestions, but I wasn't sure what the goal is for this round of edits.

This is a great question and the answer is "it depends". So the point of the whole annotation tree is to give all of that information. I think that the first level (ref=figure) annotation should just give the reader/listener enough information to know whether they need to explore the whole diagram or not. So we want to make sure all of the necessary information is in the annotation tree, but not necessarily all of it being read out at once.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

🚀 Preview available 🚀

https://05e6b36b.tbil.pages.dev

@jkostiuk jkostiuk merged commit d3e03b6 into main Feb 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants