Hacky fix for #989#1039
Merged
Merged
Conversation
siwelwerd
added
the
technical
🚀 Preview available 🚀 |
Contributor
|
Sorry this got stymied. So the CLI only doesn't xi:include when checking for asset directories, so maybe we can still pull this off. Will get something merged in (or queued up for you) now |
StevenClontz
approved these changes
May 28, 2026
Contributor
StevenClontz
left a comment
StevenClontz
left a comment
There was a problem hiding this comment.
Actually yeah we should just do this immediately and I'll refactor from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
<baseurl>in the publication file that is used for the printed Linear Algebra version. However, it is a bit hacky as if we want to publish another print book we would have to duplicate this publication file and change just the baseurl. A better way to do this will be in #1036, but the CLI doesn't seem to handle the<xi:include>s correctly right now.