Replace AsyncTask with RxJava for file list loading in MainFragment - #4690
Open
alihrhera wants to merge 1 commit into
Open
Replace AsyncTask with RxJava for file list loading in MainFragment#4690alihrhera wants to merge 1 commit into
alihrhera wants to merge 1 commit into
Conversation
- Refactor LoadFilesListTask to remove AsyncTask dependency and expose a standalone load() method - Use RxJava Single in MainFragment for asynchronous file loading and lifecycle-aware cancellation - Track loading Disposable and dispose it when starting a new load or destroying the view - Move error handling and progress updates to the reactive flow - Remove manual task state checks and rely on RxJava cancellation handling Fixes TeamAmaze#4670: New tab doubles file count
VishnuSanal
added
the
PR-Awaiting-Initial-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4670: New tab doubles file count
Description
Issue tracker
Fixes #4670
Addresses New tab doubles file count
Automatic tests
Manual tests
Done
Device: poco x60 pro
OS: 16
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
This PR used generative code tools (GenAI, LLMs, etc.)
Model:
Version:
Provider: