feat(v2): add admin GitHub App setup to Tools - #1722
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools.*locale entries to feat(i18n): localize Connectors and Tools in zh-CN #1717 so that PR owns the single mergedtoolsobject; this branch uses EnglishdefaultValues until that native-pass push landsThe page check is cosmetic: a non-admin never sees the action, but the real authorization boundary is the existing
POST /api/integrations/github-approute, protected byauthandadminAuth(afterwriteIntegrationsRateLimit). Repeated installs return the existing integration; the UI keeps the setup aside open and tells a different admin it is already owned.Evidence
docs/design/evidence/task-040-github-app-setup-before.pngdocs/design/evidence/task-040-github-app-setup-after-1200.pngdocs/design/evidence/task-040-github-app-setup-after-390.pngVerification
npx jest src/v2/__tests__/V2ConnectorTools.test.tsx --runInBand(13 tests)npx jest src/v2/__tests__/v2-layout-invariants.test.ts --runInBand(108 tests)npx jest --runInBand(108 suites, 877 tests before deferring the ten locale keys to feat(i18n): localize Connectors and Tools in zh-CN #1717)npm run typechecknpm run build