fix(v2): connector line 1 and gate pod names wrap instead of ellipsising at 390 - #1567
Merged
Merged
Conversation
…ing at 390 Two clips visible in the 390 capture of #1557 (64144): the unavailable row's first line ended in an ellipsis, and a long pod name in the gate list clipped to "Rewire Live…". Both predate the page PR; neither is meta, but the same system rule applies — shorten or wrap, never an ellipsis. Line 1 and the pod name now wrap under the mark; the invariants test pins both rules the way it already pins the meta line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1557, offered in the pod when the 390 capture was posted (64144).
Two clips at 390, both older than the page PR and neither on the meta line:
Not yet. Tell us which channel you need…) ended in an ellipsisRewire Live…Both now wrap. The system rule is the one lily-shen set for meta on #1557: shorten or wrap to two lines, never an ellipsis.
.v2-connector-row__details strongand.v2-connector-gate__poddropnowrap+text-overflowand gainoverflow-wrap: anywhere; the mark stays centred beside a two-line pod name.v2-layout-invariants.test.tspins both rules (nonowrap, notext-overflow, wrap present) the way it already pins.v2-connector-row__detail.Verified in a real browser at 390 and 1440 with a 39-character pod name and the full not-yet sentence: no element reports
scrollWidth > clientWidth; both wrap to two lines. Captures in the pod thread. Tests: 128 pass across the two suites;tsc --noEmitclean.🤖 Generated with Claude Code