Skip to content

feat(v2): rebuild workspace inspector - #1555

Merged
lilyshen0722 merged 2 commits into
mainfrom
feat/v2-workspace-inspector-artboard
Sep 6, 2026
Merged

lilyshen0722 merged 2 commits into
mainfrom
feat/v2-workspace-inspector-artboard

Conversation

@lilyshen0722

Copy link
Copy Markdown
Contributor

Summary

  • Replace the legacy 86 KB tabbed inspector with a focused V2Inspector card stack: agents, needs you, and board.
  • Preserve agent profile, invite, board, and authorized attachment exits without retaining the old inspector surface.
  • Make the inspector a 300px desktop column and a bottom sheet at phone widths; add static layout guards for the replacement.

Stack

Verification

  • npx jest --runInBand src/v2/__tests__/v2-layout-invariants.test.ts src/v2/__tests__/V2Inspector.test.tsx src/i18n/__tests__/translationKeys.test.ts (92 passed)
  • npm run typecheck
  • npm test -- --watchAll=false (88 suites, 581 tests)
  • npm run build
  • Mutation: removing the selected-pod attention filter makes V2Inspector.test.tsx fail (stale other-pod item renders).

UX validation is intentionally pending the combined workspace cutover and its 1440/390 walk.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: CHANGES_REQUESTED @ e6c0889 — walked in the full stack (built at #1556 639a9ea) at 1440 + 390 beside the Workspace frames; sheet in Sprint HQ. Passing: 300px column on the ground, three white cards r6 with mono 11 lowercase labels, 28px square avatars, name 600 + muted status, needs-you card, board counts line + rows with mono meta, members · manage at the foot; 390 sheet slides up over the thread with the cards intact. Four fixes: (1) agent dot 8px square (both frames measure 8px; built 6px); (2) foot links members · manage in mono 11 lowercase muted (built UA 13.33px buttons); (3) card avatars are plain squares — drop the shared avatar's 2px white border + shadow; (4) empty needs-you copy per the after-pick frame: 'Nothing. are working.' / 'Nothing open.' when none; and the × belongs to the 390 sheet only (the 1440 artboard closes from the header toggle). Also: the sheet's open affordance at 390 is PR 3's header (the toggle is display:none there today).

@samxu01
samxu01 force-pushed the feat/v2-workspace-inspector-artboard branch from 74e24f9 to 199e905 Compare September 5, 2026 14:09

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: APPROVED @ 199e905 — walked in the restacked build (#1556 089c990) at 1440 + 390 beside the Workspace frames. All four items from e6c0889 are closed: agent dot 8px square, foot links members · manage in mono 11 lowercase, card avatars plain 28px squares (no ring, no shadow), empty needs-you reads 'Nothing open.', and the × is hidden at 1440 and present on the 390 sheet. The 390 sheet slides up over the thread at 14px padding and now closes when the drawer opens (and vice versa). Sheet in Sprint HQ.

@samxu01
samxu01 force-pushed the feat/v2-workspace-inspector-artboard branch 2 times, most recently from a8f9449 to a6f10d4 Compare September 5, 2026 14:22
@samxu01
samxu01 force-pushed the feat/v2-workspace-sidebar-artboard branch from d5b0f3b to 82fa5ef Compare September 5, 2026 14:23
@samxu01
samxu01 force-pushed the feat/v2-workspace-inspector-artboard branch from a6f10d4 to b6adfa3 Compare September 5, 2026 14:24

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: APPROVED @ a6f10d4 — restack of the approved 199e905 on #1549 d5b0f3b; inspector re-measured in the stacked build at 1440 (x 1126, w 300, three cards, 8px dots, mono foot links, plain 28px square avatars, 'Nothing open.') and at 1200 / 1024 (column holds 300 while the chat shrinks); 390 sheet unchanged. Sheet in Sprint HQ.

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: APPROVED @ b6adfa3 — restack of the approved inspector on #1549 82fa5ef (the tablet-token deletion now lives in #1556 7ef104e, which I walked at the stack top: inspector 300px column at 1440 and 1200, sheet at 390). No inspector change.

@samxu01
samxu01 force-pushed the feat/v2-workspace-inspector-artboard branch from b6adfa3 to bcb58d7 Compare September 6, 2026 01:40

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: APPROVED @ bcb58d7 — restack of the approved b6adfa3 onto #1549 43e237c: the PR's non-test patch against its base is line-identical to the approved one (added/removed lines compared; no difference). Inspector walk from 7ef104e stands.

@lilyshen0722
lilyshen0722 changed the base branch from feat/v2-workspace-sidebar-artboard to main September 6, 2026 01:49
@samxu01
samxu01 force-pushed the feat/v2-workspace-inspector-artboard branch from bcb58d7 to baf51ba Compare September 6, 2026 02:01

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-GATE: APPROVED @ baf51ba — carried from bcb58d7: rebased onto main 49fa525; the PR's patch against its base is line-identical to the approved one, both with tests excluded (nothing that renders changed) and with all files included (nothing at all changed). Clear to press.

@lilyshen0722
lilyshen0722 merged commit b0b4759 into main Sep 6, 2026
15 checks passed
@lilyshen0722
lilyshen0722 deleted the feat/v2-workspace-inspector-artboard branch September 6, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant