Skip to content

feat(slack): add installable connector page flow - #1538

Merged
lilyshen0722 merged 4 commits into
mainfrom
kai/slack-installable-page
Sep 4, 2026
Merged

feat(slack): add installable connector page flow#1538
lilyshen0722 merged 4 commits into
mainfrom
kai/slack-installable-page

Conversation

@lilyshen0722

@lilyshen0722 lilyshen0722 commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary:

  • enable Slack in the Connectors installable flow
  • add server-built OAuth, a separate authorization tab, and owner confirmation/rejection states
  • reuse lifecycle install, pending, and uninstall handling across Telegram and Slack

Validation:

  • V2ConnectorsPage Jest suite: 22 passing
  • frontend typecheck passed
  • scoped ESLint: 0 errors (existing TSX filename warnings)

Dependency: do not merge before #1537. After #1537 merges, this branch will be rebased onto main so only the page diff remains.

@lilyshen0722
lilyshen0722 changed the base branch from kai/slack-installable-backend to main September 4, 2026 09:22
@samxu01
samxu01 force-pushed the kai/slack-installable-page branch from 626d2ae to 4de3408 Compare September 4, 2026 09:24
github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 4, 2026
View reviewed changes
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/webhooks/slack.ts Fixed
Comment thread backend/routes/installables.ts Fixed
Comment thread backend/routes/installables.ts Fixed
@samxu01
samxu01 force-pushed the kai/slack-installable-page branch 2 times, most recently from d57ae3c to 3b7dc53 Compare September 4, 2026 10:17
github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 4, 2026
View reviewed changes
Comment thread backend/routes/installables.ts Fixed
@samxu01
samxu01 force-pushed the kai/slack-installable-page branch 7 times, most recently from 0848178 to c2d8eb3 Compare September 4, 2026 13:44
@lilyshen0722 lilyshen0722 mentioned this pull request Sep 4, 2026
Merged
@samxu01
samxu01 force-pushed the kai/slack-installable-page branch 5 times, most recently from 3cfe005 to 280a43a Compare September 4, 2026 20:04
@samxu01
samxu01 force-pushed the kai/slack-installable-page branch from 280a43a to bcb75a4 Compare September 4, 2026 20:22
@lilyshen0722
lilyshen0722 merged commit 4a96864 into main Sep 4, 2026
14 checks passed
@lilyshen0722
lilyshen0722 deleted the kai/slack-installable-page branch September 4, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lilyshen0722 @github-advanced-security