feat(seo): add AI agent runtime guide - #1396
Conversation
lilyshen0722
left a comment
There was a problem hiding this comment.
Gated at 506533c3. Third guide carrying the same two non-existent event types. The routes and the ack contract are correct; the event table is not.
Verified real:
GET /api/agents/runtime/events—backend/routes/agentsRuntime.ts:447, mounted atserver.ts:218.POST /api/agents/runtime/events/:id/ack—agentsRuntime.ts:1157.- "If a polled event supplies
payload.deliveryId, the acknowledgement must echo that exact value." — exactly the implemented contract atagentsRuntime.ts:1115–1145, including theisDeliveryNonceRequiredgate and the ADR-026 D6 behaviour. - "do not confuse delivery with outcome" — correct, and a genuinely useful thing to tell a runtime author.
The event table repeats #1391 for the third time.
["task.assigned", "A task was assigned to that agent."]
["integration.event", "An external integration produced an input with a source and data payload."]
integration.event has no producer anywhere in the repo — the real type is integration.summary (agentEventService.ts:351). task.assigned is an AgentRun.trigger value (models/AgentRun.ts:116, nativeRuntimeService.ts:609), not an AgentEvent.type; nothing constructs an event with it. Same two rows as #1388 and #1393, tracked in #1391.
This instance is worse than #1393's, and the difference is worth being precise about. The lead-in hedges — "Commonly documents these event categories" — which is true. But the table's own header is "What it means for a runtime", and the rows are written as runtime semantics: "A task was assigned to that agent", "An external integration produced an input." A runtime author reading this table will poll GET /events expecting two types that will never arrive. The hedge sits one line above a table that reads as the runtime's event vocabulary, so it does not do the work it appears to do.
chat.mention, thread.mention and heartbeat are all real, so three of five rows are correct — which is precisely what makes the other two costly here. This is the guide a runtime author reads first.
Suggested fix, consistent with #1391: integration.event → integration.summary; drop task.assigned or move it to a separately-labelled "run triggers" list; consider adding message.posted, which has 6 producers and is the entire wake-on-message path yet appears in none of the four guides.
Mechanical: all 29 pages rendered — 0 [object Object], 0 stray undefined, no token-shaped strings. node --test scripts/generate-seo-pages.test.mjs 2/2 on Node 22. Base is current main (0 behind). Most checks still pending at review time; Detect secrets, Source changed ⇒ version bumped and Stale-base merge guard have passed.
Process note rather than a code note: three PRs have now shipped or proposed these two rows, each independently, each with a green string-presence test. That is not three authors making the same mistake — it is one wrong docs-site/ entry being read three times. The fix that ends it is upstream in docs-site/agents/events.mdx, plus a guard that resolves documented identifiers against their producers. Both are in #1391.
…e no producer (#1397) * docs(agents): correct the event vocabulary — two documented types have no producer `docs-site/agents/events.mdx` and `runtime-protocol.mdx` are the source that three SEO guides (#1388, #1393, #1396) copied their event tables from, so a wrong row here reaches public crawlable pages. Verified every row against its producer at origin/main: - `integration.event` does not exist. The real types are `integration.summary` (telegram/groupme/scheduler) and `discord.summary` for Discord specifically (schedulerService.ts:741). The payload is `{summary, integrationId, source}`, plus `{trigger, silent}` when scheduled — there is no `data` field. - `task.assigned` is not an event type. It is an `AgentRun.trigger` value (models/AgentRun.ts:116, nativeRuntimeService.ts:609); nothing constructs an AgentEvent with it, so a runtime polling GET /events never receives one. - `message.posted` was missing entirely despite having 6 producers and being the whole wake-on-message path. - The mention payloads carry `content`, not `text` — and `mentions`, `source`, `messageType`, `createdAt`, `thread` were undocumented. - The heartbeat payload does not contain `memoryFiles`, `recentMessages`, `pendingTasks` or `context`. It is `{trigger, generatedAt, podId, activityHint, policy, content}`, with the steering inline in `content`. - `DISCORD_GUILD_ID` is read by no application code; the guild id comes from the Integration record (discordService.ts:240). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(agents): add the three peer-addressed event types the table still omitted Follow-up on @pod-architect's review of the parent commit. Their widening holds — I re-derived each producer rather than taking it on report: - `agent.ask` (agentAskService.ts:214) and `agent.ask.response` (:281) are addressed to an arbitrary `targetAgent` / `ask.fromAgent`, so any BYO runtime receives them. - `ensemble.turn` (agentEnsembleService.ts:285) is addressed to any ensemble member. The load-bearing fact is that GET /events applies no type filter: the query is `{agentName, instanceId, status:'pending'}` plus an optional podId (agentEventService.ts:1231). A runtime is delivered every type enqueued against its identity, so an omission from this table reads as absence and is wrong in the same way a fictional row is. `summary.request` and `user.message` stay omitted from the table but are now named as first-party-only — hardcoded to `commonly-bot` (agentMentionService.ts :267, routes/summaries.ts:324) and the managed-agents tier (managedAgentsAdapter.ts:364) respectively. Also records why both failure directions were silent: `AgentEvent.type` is `{type: String, required: true}` with no enum (models/AgentEvent.ts:84), so nothing validates a type name either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Summary
Verification
Release readiness
Ready with follow-ups: additive static/SPA content only; no migration or runtime permission change. Rollback is a revert. CI must be green before merge.