Skip to content

Remove redundant code comments - #10

Merged
TayHCode merged 1 commit into
mainfrom
no-comments
Oct 15, 2026
Merged

TayHCode merged 1 commit into
mainfrom
no-comments

Conversation

@TayHCode

@TayHCode TayHCode commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Remove 11 redundant comment tokens across 3 first-party code files. Application code is unchanged. Reviewed all first-party code; dependency, vendor, generated and documentation-only files were excluded. Protected contracts, directives, security reasons and platform constraints remain.

Upstream: pstack 0.15.25, cursor/plugins at e5136d82418d2db3165ea1050d17577cd618cc05, no-comments / Comment Sicko workflow, with the authorized conservative comment-only exceptions.

Validation: Edited TypeScript/TSX emits byte-identical JavaScript with comments removed. CSS executable text is identical after comment/whitespace stripping. git diff --check passed; additions are blank lines only.

  • npm run build: PASS.

  • npm ci: PASS.

  • npm pack --dry-run: PASS.

  • npm test: PASS.

  • npm run typecheck: PASS.

Receipt status: PASS.

Retained workaround/refactor candidates:

  • src/server/live.ts:100

    Exact comment:

// Some setups put an agent's display name in `agent`; the real kind is then in the session record.

Why: Upstream agent data can put display names in the kind field. Proposed change: Introduce a typed normalization adapter for upstream Herdr records and retain mixed-format fixtures.

  • src/server/setup.ts:103

    Exact comment:

/* `pair` will then say Control Center is not running */ }

Why: Runtime metadata reads can fail until pairing reports availability. Proposed change: Return an explicit unavailable result from runtime lookup; preserve the fallback until callers handle it.

  • src/server/devices.ts:51

    Exact comment:

/* devices then last only until restart */ }

Why: Persistent device storage can fail and fall back to memory. Proposed change: Represent persistence capability in device-store state and expose the limited lifetime explicitly.

  • src/client/api.ts:29

    Exact comment:

/* storage may be unavailable */ }

Why: Browser storage may be unavailable. Proposed change: Extract a storage capability adapter with explicit unavailable handling; retain browser fallback.

  • src/client/lib/archive.ts:19

    Exact comment:

/* optional */ }

Why: Browser storage is optional and failures are swallowed. Proposed change: Use a shared optional-storage adapter and make persistence availability explicit.

  • src/client/lib/prefs.ts:19

    Exact comment:

/* optional */ }

Why: Browser storage is optional and failures are swallowed. Proposed change: Use a shared optional-storage adapter and preserve session-only behavior.

  • src/client/components/Shell.tsx:16

    Exact comment:

/* optional */ }

Why: Theme persistence is optional and storage failures are swallowed. Proposed change: Use the same optional-storage adapter as preferences; preserve browser fallback.

  • src/client/App.tsx:25

    Exact comment:

// Back/forward or a switch to another Herdr session must not briefly show the previous session's agents.

Why: Session navigation can briefly display agents from the prior session. Proposed change: Tie cached agent state to a session identity and render only matching snapshots.

  • src/client/App.tsx:38

    Exact comment:

// The pane you are looking at stays visible even when "hide other panes" is on, so direct links keep working.

Why: Direct links must keep their target pane visible despite a filter preference. Proposed change: Represent explicit navigation selection separately from list visibility preferences.

  • src/server/live.ts:92

    Exact comment:

// An unnamed agent alone in its workspace takes the workspace's name; otherwise fall back to its terminal title.

Why: Unnamed agents need workspace or terminal-title fallbacks. Proposed change: Normalize agent display identity in the upstream adapter with explicit fallback sources.

  • src/client/pages/AgentPage.tsx:52

    Exact comment:

// Drop the agent TUI's own footer (composer box, model/status line) so the transcript ends at the last real output.

Why: Raw terminal output includes an agent composer/footer rather than transcript content. Proposed change: Use a named terminal-transcript adapter with fixtures for supported TUI footer formats.

  • src/client/pages/AgentPage.tsx:174

    Exact comment:

// A console has no session log worth showing, so its chat is read from its terminal lines.

Why: Custom consoles lack structured session logs. Proposed change: Expose terminal-derived chat as a distinct source capability with its limited parsing contract.

No merge performed; owner review and CI disposition remain required.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T16:14:59.755446Z 25e31ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TayHCode
TayHCode merged commit 25e31ca into main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant