Skip to content

feat: run comparison - run picker & switcher - #2634

Open
camielvs wants to merge 1 commit into
cmp-07-graph-diff-viewfrom
cmp-08-run-picker
Open

feat: run comparison - run picker & switcher#2634
camielvs wants to merge 1 commit into
cmp-07-graph-diff-viewfrom
cmp-08-run-picker

Conversation

@camielvs

@camielvs camielvs commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Description

The Compare Runs stack needs a way to actually choose the two runs you're comparing. This PR adds that: the run chips in the page header, and the dialog behind them.

  • Run chips (A and B) — each side of the comparison is a small coloured chip: blue for A, green for B. The chip shows the pipeline name and run number, and gives you three things: click the name to open that run in a new tab, a swap-in button to replace it with a different run, and an to clear the slot. An empty slot is a dashed "Select run A / B" button instead.
  • Run picker dialog — opens from either chip. It's a searchable list of recent runs with:
    • search by pipeline name (debounced, with a clear button),
    • a created by filter,
    • a date range filter (UTC),
    • one row per run showing status icon, pipeline name, run number, the task status bar, when it ran and who ran it.
  • The run already selected on the other side is filtered out of the list, so you can't accidentally compare a run with itself.

Two small things worth knowing:

Related Issue and Pull requests

Part of the Compare Runs stack. Builds on #2602, consumed by #2603 (#2596#2603).

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

These components are only visible once #2603 is in, so test from the tip of the stack:

  1. Enable the Compare runs flag under Settings → Beta features and open the compare page.
  2. Click Select run A — the picker opens. Try each filter: type a pipeline name, pick a created by value, set a date range. Confirm the list narrows and shows "No runs match your filters." when nothing matches.
  3. Pick a run — the dialog closes and the chip fills in with the pipeline name and run number.
  4. Repeat for B, and confirm the run you picked for A is not in B's list.
  5. On a filled chip: click the name (opens that run in a new tab), the swap-in icon (reopens the picker), and (clears the slot).
  6. Confirm the runs dashboard still lists and filters runs as before — the picker shares its query cache.

Additional Comments

No existing behaviour changes; everything here is new and scoped to the compare page.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: cmp-08-run-picker/7766fb7

camielvs commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Comment thread src/routes/v2/pages/CompareView/hooks/useCompareRunList.ts Outdated
Comment thread src/routes/v2/pages/CompareView/components/RunSwitcher.tsx Outdated
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from 1ac3709 to 7b1a733 Compare August 17, 2026 23:03
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from 7b1a733 to 38a92d3 Compare August 18, 2026 00:44
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from 38a92d3 to 05c821c Compare August 18, 2026 00:56
@camielvs
camielvs marked this pull request as ready for review August 18, 2026 01:20
@camielvs
camielvs requested a review from a team as a code owner August 18, 2026 01:20
Comment thread src/routes/v2/pages/CompareView/components/RunPickerDialog.tsx
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from 05c821c to fdf1dea Compare August 18, 2026 21:00
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from fdf1dea to 692cfe3 Compare August 18, 2026 21:59
@camielvs
camielvs force-pushed the cmp-07-graph-diff-view branch from 692cfe3 to 5103b93 Compare August 18, 2026 23:07
@camielvs
camielvs requested a review from Mbeaulne August 19, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants