exploration: Tangent Shell in Tangle - #2618
Draft
camielvs wants to merge 1 commit into
Draft
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| const measure = () => | ||
| setOverflowing(el.scrollHeight > COLLAPSED_MAX_PX + 1); | ||
| measure(); | ||
| const observer = new ResizeObserver(measure); |
Comment on lines
+188
to
+192
| const observer = new ResizeObserver(() => { | ||
| if (stickyRef.current && isScrollQuiet()) { | ||
| scrollToLastRow(virtualizerRef.current, rowCountRef.current); | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EXPLORATION / PROOF-OF-CONCEPT
Adds Tangent-Shell UI to Tangle.
This is done by bringing over the entire tangent-shell frontend codebase and merging it with Tangle's existing UI primitives and structure where possible. Due to this de-dupe, the tangent-shell UI is reduced from ~20k lines to ~12k lines. (there's a lot fo shared code with tangle-ui!).
The tangent-shell feature is accessible from the homepage after activating the beta.
THis is 100% vibed with Claude as an exploration. The core tangent-shell features appear to work, but there may be some things that do not.
TO USE TANGENT SHELL INSIDE TANGLE YOU MUST RUN THE TANGENT SHELL BACKEND (or full app) AND POINT IT TO PORT 8787.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
tangentshellintangleexploration.mov (uploaded via Graphite)
Test Instructions
To test this you need the following repos up and running:
Then activate the beta inside tangle-ui and you can now navigate to
/shelland see you previous tangent sessions!Additional Comments