draft#917
Merged
Merged
Conversation
crutchcorn
reviewed
May 12, 2026
Sheraff
reviewed
May 12, 2026
Contributor
Sheraff
left a comment
Sheraff
left a comment
There was a problem hiding this comment.
I think this is good and straight to the point.
If i were a hater I would say that the "what we're working on next" doesn't feel like enough: it patches this type of security issues, but what are we doing for our broader security posture?
Co-authored-by: Flo <me@florianpellet.com>
20jasper
reviewed
May 12, 2026
20jasper
left a comment
20jasper
left a comment
There was a problem hiding this comment.
I think tonally everything is good and responsibility is well accepted. I think this has a bit too much overlap with the postmortem article linked up front. Consider a quick "this was a cache poisoning and permissions attack caused by this notorious GHA feature, read more on the root cause here"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.