Fix blog filter edge cases - #1180
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 5ce392b | Commit Preview URL Branch Preview URL |
Aug 25 2026, 02:18 PM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe blog route validates author query values against available authors. Invalid values become no selection, so all posts remain visible. The author select uses the validated value. The closed mobile filter panel is hidden from assistive technology and cannot receive interaction. ChangesBlog filters
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The changes align invalid author URLs and closed mobile filter controls with the interface behavior users see; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Evidence
The design-system blog refresh left two filter edge cases on main:
authorquery displayedAll authors, but still filtered posts using the unknown value. A stale, mistyped, or manually edited URL therefore showed an empty blog while the visible filter said all authors were selected. This remained as an unresolved finding on merged PR Design system refresh: Tabs, Panel, neutral badges, squircles + blog polish #1171: Design system refresh: Tabs, Panel, neutral badges, squircles + blog polish #1171 (comment)Final title, body, keyword, and open-PR file searches found no issue or active change covering either behavior.
Impact
Invalid author URLs now behave consistently as
All authors, and keyboard users no longer tab into closed mobile filter controls.Change
inertandaria-hiddenstate to the collapsed mobile filter container.Validation
pnpm testafter each changegit diff --checkThe first sandboxed test attempt hit the known macOS TSX IPC
EPERM; the identical escalated run and all later full runs passed.Risk
Low. Valid author filters and open mobile filters are unchanged. The changes only align hidden or invalid states with what the interface already communicates.
Summary by CodeRabbit