Skip to content

Keep Charts preview history in sync #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tannerlinsley wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −16
Open

Keep Charts preview history in sync #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/components/charts/ChartsCatalogResult.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,12 @@ export function ChartsCatalogResult({
if (!trustedUrl) return
const currentHistory = previewHistoryRef.current
const currentUrl = currentHistory.entries[currentHistory.index] ?? '/'

setPreviewHistory((current) => {
const next = updateExamplePreviewHistory(current, {
kind: message.navigationKind,
url: trustedUrl,
})
previewHistoryRef.current = next
return next
const nextHistory = updateExamplePreviewHistory(currentHistory, {
kind: message.navigationKind,
url: trustedUrl,
})
previewHistoryRef.current = nextHistory
setPreviewHistory(nextHistory)
setPreviewNavigationError('')
if (message.navigationKind === 'load' || currentUrl !== trustedUrl) {
setPreviewAnnotationTarget(undefined)
Expand Down
13 changes: 5 additions & 8 deletions src/components/charts/ChartsNotebookPage.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,15 +808,12 @@ export function ChartsNotebookPage() {
if (!trustedUrl) return
const currentHistory = previewHistoryRef.current
const currentUrl = currentHistory.entries[currentHistory.index] ?? '/'

setPreviewHistory((current) => {
const next = updateExamplePreviewHistory(current, {
kind: message.navigationKind,
url: trustedUrl,
})
previewHistoryRef.current = next
return next
const nextHistory = updateExamplePreviewHistory(currentHistory, {
kind: message.navigationKind,
url: trustedUrl,
})
previewHistoryRef.current = nextHistory
setPreviewHistory(nextHistory)
setPreviewNavigationError('')
if (message.navigationKind === 'load' || currentUrl !== trustedUrl) {
setPreviewAnnotationTarget(undefined)
Expand Down
Loading