Skip to content

test(router-core): document U+0130 affix limitation #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 5 commits into from
Aug 22, 2026
+11 −4
Merged

test(router-core): document U+0130 affix limitation #8149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4efe356
fix(router-core): match Unicode wildcard suffixes
Sheraff Aug 22, 2026
da071bb
ci: apply automated fixes
autofix-ci[bot] Aug 22, 2026
0d04894
refactor(router-core): clarify wildcard suffix boundaries
Sheraff Aug 22, 2026
e8c829c
fix(router-core): handle Unicode parameter affixes
Sheraff Aug 22, 2026
32104f6
test(router-core): document U+0130 affix limitation
Sheraff Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions e2e/react-start/basic/rsbuild.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ const outDir = process.env.E2E_DIST_DIR ?? 'dist'
const startModeConfig = getStartModeConfig()

export default defineConfig({
plugins: [
pluginReact(),
tanstackStart(startModeConfig),
],
plugins: [pluginReact(), tanstackStart(startModeConfig)],
output: {
distPath: {
root: outDir,
Expand Down
10 changes: 10 additions & 0 deletions packages/router-core/tests/new-process-route-tree.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,16 @@ describe('findRouteMatch', () => {
const tree = makeTree(['/{$}/c/file'])
expect(findRouteMatch('/a/b/c/file', tree)?.route.id).toBe('/{$}/c/file')
})

it.fails('matches U+0130 wildcard suffixes case-insensitively', () => {
// U+0130 is currently the only character whose default lowercase mapping
// changes UTF-16 length, so its folded length cannot index the raw URL.
const tree = makeTree(['/{$}İ'])
expect(findRouteMatch('/valueİ', tree)?.rawParams).toEqual({
'*': 'value',
_splat: 'value',
})
})
it('multi-segment wildcard w/ prefix and suffix', () => {
const tree = makeTree(['/file{$}end'])
expect(findRouteMatch('/file/a/b/c/end', tree)?.route.id).toBe(
Expand Down
Loading