Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughCorrects type inference for the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-router/tests/Matches.test-d.tsx`:
- Line 3: There are duplicate type-only imports from '../src' (e.g.,
MakeMatchRouteOptions and the other type imported later); consolidate them into
a single type import statement by combining the named types (e.g., import type {
MakeMatchRouteOptions, <OtherTypeName> } from '../src') and remove the redundant
import so lint rule import/no-duplicates is satisfied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 62e86816-93f3-4106-9108-8e97fc606791
📒 Files selected for processing (6)
.changeset/fair-phones-grow.mdpackages/react-router/src/Matches.tsxpackages/react-router/tests/Matches.test-d.tsxpackages/solid-router/src/Matches.tsxpackages/solid-router/tests/Matches.test-d.tsxpackages/vue-router/src/Matches.tsx
Contributor
|
View your CI Pipeline Execution ↗ for commit 44eb409
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview3 package(s) bumped directly, 9 bumped as dependents. 🟩 Patch bumps
|
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied
We fixed the ESLint failures in Matches.test-d.tsx for both react-router and solid-router by correcting the import ordering introduced by the PR. The PR added new type imports (MakeMatchRouteOptions and React) before the existing regular '../src' import, violating import/order (regular imports must precede type-only imports) and creating duplicate '../src' entries that violated import/no-duplicates. These changes reorder the imports so all regular imports appear first, followed by type-only imports, and merge the duplicate '../src' type imports into a single statement.
Tip
✅ We verified this fix by re-running @tanstack/solid-router:test:eslint, @tanstack/react-router:test:eslint.
Suggested Fix changes
diff --git a/packages/react-router/tests/Matches.test-d.tsx b/packages/react-router/tests/Matches.test-d.tsx
index 479b41d788..89e1088454 100644
--- a/packages/react-router/tests/Matches.test-d.tsx
+++ b/packages/react-router/tests/Matches.test-d.tsx
@@ -1,6 +1,4 @@
import { expectTypeOf, test } from 'vitest'
-import type * as React from 'react'
-import type { MakeMatchRouteOptions } from '../src'
import {
MatchRoute,
createRootRoute,
@@ -10,7 +8,8 @@ import {
useMatchRoute,
useMatches,
} from '../src'
-import type { AnyRouteMatch, RouteMatch } from '../src'
+import type * as React from 'react'
+import type { AnyRouteMatch, MakeMatchRouteOptions, RouteMatch } from '../src'
const rootRoute = createRootRoute()
diff --git a/packages/solid-router/tests/Matches.test-d.tsx b/packages/solid-router/tests/Matches.test-d.tsx
index 16bd90e8a3..346e8c45cb 100644
--- a/packages/solid-router/tests/Matches.test-d.tsx
+++ b/packages/solid-router/tests/Matches.test-d.tsx
@@ -1,5 +1,4 @@
import { expectTypeOf, test } from 'vitest'
-import type { MakeMatchRouteOptions } from '../src'
import {
MatchRoute,
createRootRoute,
@@ -11,6 +10,7 @@ import {
} from '../src'
import type { AnyRouteMatch, RouteMatch } from '@tanstack/router-core'
import type * as Solid from 'solid-js'
+import type { MakeMatchRouteOptions } from '../src'
const rootRoute = createRootRoute()
➡️ This fix was applied by manuel.schiller@caligano.de
🎓 Learn more about Self-Healing CI on nx.dev
Contributor
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
Co-authored-by: schiller-manuel <schiller-manuel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7128
Summary by CodeRabbit
Bug Fixes
Tests
Documentation