Fix: enable dev server back in test mode

[luixo]

Closes #4620 (comment)

This was already open: #4642
I accidentally removed the fork while cleaning up repos in my account.

Summary by CodeRabbit

• Refactor
  • Simplified dev server plugin configuration by removing test mode-specific conditional logic. The dev server now follows a unified execution path for consistent behavior across all runtime modes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[nicksrandall]

Is this PR still needed?

[luixo]

The code is still there:

router/packages/start-plugin-core/src/dev-server-plugin/plugin.ts

Lines 22 to 24 in a3e7d80

	config(_userConfig, { mode }) {
	isTest = isTest ? isTest : mode === 'test'
	},

A pity it takes more than half a year to merge 10 LOC PR :(

[coderabbitai]

📝 Walkthrough

Walkthrough

The dev server plugin's mode-based test gating has been removed. The isTest flag, mode-based configuration hook, and early return in configureServer have been deleted, allowing the dev server to run without branching logic regardless of environment mode.

Changes

Cohort / File(s)	Summary
Dev Server Plugin Mode Gating Removal packages/start-plugin-core/src/dev-server-plugin/plugin.ts	Removed isTest flag initialization, deleted config hook that set isTest based on mode, and removed early return in configureServer that short-circuited execution in test mode. Server now runs unconditionally.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A gate that blocked the test-mode stream,
Has vanished like a forgotten dream—
No flags, no checks, no turning back,
The dev server's on the beaten track! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: enabling the dev server in test mode, which directly addresses the core issue of the PR.
Linked Issues check	✅ Passed	The changes directly address issue #4620 by removing the isTest flag and mode-based gating that prevented the dev server from running in test mode, fully satisfying the requirement.
Out of Scope Changes check	✅ Passed	All changes are focused on re-enabling the dev server in test mode as specified in the linked issue; no out-of-scope modifications were introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3e7d80 and 0436206.

📒 Files selected for processing (1)

• packages/start-plugin-core/src/dev-server-plugin/plugin.ts

💤 Files with no reviewable changes (1)

• packages/start-plugin-core/src/dev-server-plugin/plugin.ts

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}