Repository navigation
docs(svelte): import browser from $app/env instead of $app/environment - #11936
pieralukasz wants to merge 1 commit into
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Svelte SSR guide and seven example layouts now import ChangesSvelteKit environment imports
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The changed imports are supported in the examples, and the guide uses the documented SvelteKit 3 API. No concrete merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
SvelteKit 3 deprecated
$app/environmentin favour of$app/env. With 3.0.1, importing from$app/environmentlogs "$app/environmentis deprecated, use$app/envinstead" in dev, and svelte-check can't find its types. I hit this while setting up svelte-query in a new SvelteKit 3 app and copying from the SSR guide.This swaps the import in the Svelte SSR guide and in the 7 Svelte examples.
$app/envhas the samebrowserexport and exists since SvelteKit 2.63, and the examples are on ^2.70.3, so nothing else changes. I ran svelte-check and a build on thebasicandssrexamples with their current dependencies, both clean.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
$app/envfor browser detection.