fix(solid-query): prevent lost updates when mounting cached queries - #11385
fix(solid-query): prevent lost updates when mounting cached queries#113852wheeh wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1c6cac9 to
9d49169
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
9d49169 to
83d1ac1
Compare
fixes #11384
🎯 Changes
Fixes a Solid Query timing issue where updates could be lost when a cached query refetched during mount.
Observer attachment is deferred until the conditional subtree is ready, while the optimistic fetch status remains available synchronously. Regression tests cover the behavior in both browser and semantic tests.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact