Skip to content

fix(solid-query): prevent lost updates when mounting cached queries - #11385

Open
2wheeh wants to merge 4 commits into
TanStack:solid-query-v6-prefrom
2wheeh:fix/solid-query-mount-notification
Open

fix(solid-query): prevent lost updates when mounting cached queries#11385
2wheeh wants to merge 4 commits into
TanStack:solid-query-v6-prefrom
2wheeh:fix/solid-query-mount-notification

Conversation

@2wheeh

@2wheeh 2wheeh commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

fixes #11384

🎯 Changes

Fixes a Solid Query timing issue where updates could be lost when a cached query refetched during mount.

Observer attachment is deferred until the conditional subtree is ready, while the optimistic fetch status remains available synchronously. Regression tests cover the behavior in both browser and semantic tests.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f0d9376d-c0d6-4456-9d13-8b253ac22cbf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@2wheeh
2wheeh marked this pull request as ready for review September 3, 2026 16:22
@2wheeh
2wheeh marked this pull request as draft September 3, 2026 16:22
@2wheeh
2wheeh force-pushed the fix/solid-query-mount-notification branch 3 times, most recently from 1c6cac9 to 9d49169 Compare September 10, 2026 03:30
@2wheeh
2wheeh marked this pull request as ready for review September 10, 2026 03:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T03:36:27.829358Z 9d49169 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@2wheeh
2wheeh force-pushed the fix/solid-query-mount-notification branch from 9d49169 to 83d1ac1 Compare September 10, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant