chore(scripts/generate-docs): add 'react-query' to TypeDoc generation targets - #11205
chore(scripts/generate-docs): add 'react-query' to TypeDoc generation targets#11205sukvvon wants to merge 6 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 22e2d44
☁️ Nx Cloud last updated this comment at |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe documentation generation script no longer generates Preact reference documentation. ChangesDocumentation generation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change stops automatic TypeDoc generation for preact-query so manually authored reference documentation is preserved; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
size-limit report 📦
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…c generation targets" This reverts commit 1936431.
🎯 Changes
Adds
react-queryto thepkgarray inscripts/generate-docs.ts, soreact-query's reference docs can be generated by TypeDoc (mirroring the existing setup forangular-query-experimental,svelte-query,preact-query, andlit-query).This is the next step after #11204, which ported the hand-written React reference docs into
preact-query's JSDoc and validated that TypeDoc's output holds up against the actual types with minimal loss of information. This PR applies the same approach toreact-queryitself.Still a draft: the script change alone is enough to review, but merging it means the next
pnpm run generate-docsrun will wipe and regeneratedocs/framework/react/reference/, which currently holds the hand-written docs. That requires porting the same JSDoc intoreact-query's source first (the actualreact-queryequivalent of #11204) — this PR isn't wired up to run yet.Options inherited from
query-core(e.g.staleTime,retry,gcTime) remain out of scope —generate-docs.tsexcludesquery-corefrom all TypeDoc entry points, so that's a separate follow-up.✅ Checklist
pnpm run test:pr.🚀 Release Impact