fix(examples): use webpack in Next.js examples for StackBlitz compatibility#11110
Open
MaNaN1803 wants to merge 1 commit into
Open
fix(examples): use webpack in Next.js examples for StackBlitz compatibility#11110MaNaN1803 wants to merge 1 commit into
MaNaN1803 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (9)
📝 WalkthroughWalkthroughUpdated 11 Next.js example and integration ChangesNext.js Webpack development scripts
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/vue-query/src/queryClient.ts (1)
197-226: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd regression coverage for callable reactive inputs.
Please add runtime and type-level tests in
packages/vue-query/src/__tests__/queryClient.test.tscovering function-basedfilters,options, nested refs,queryKeygetters, andrefetchTypebehavior. These overloads introduce both a new public type contract and a new normalization path.Also applies to: 296-330
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/vue-query/src/queryClient.ts` around lines 197 - 226, Add regression coverage in queryClient.test.ts for invalidateQueries, exercising callable filters and options with nested refs, queryKey getters, and refetchType behavior at runtime. Add type-level assertions confirming these function-based inputs satisfy the new invalidateQueries overloads and preserve the public contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-query/src/queryClient.ts`:
- Around line 197-226: Add regression coverage in queryClient.test.ts for
invalidateQueries, exercising callable filters and options with nested refs,
queryKey getters, and refetchType behavior at runtime. Add type-level assertions
confirming these function-based inputs satisfy the new invalidateQueries
overloads and preserve the public contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6c914438-e201-4b86-928a-5af200a3336a
📒 Files selected for processing (12)
examples/react/auto-refetching/package.jsonexamples/react/infinite-query-with-max-pages/package.jsonexamples/react/load-more-infinite-scroll/package.jsonexamples/react/nextjs-app-prefetching/package.jsonexamples/react/nextjs/package.jsonexamples/react/optimistic-updates-cache/package.jsonexamples/react/optimistic-updates-ui/package.jsonexamples/react/pagination/package.jsonexamples/react/prefetching/package.jsonintegrations/react-next-15/package.jsonintegrations/react-next-16/package.jsonpackages/vue-query/src/queryClient.ts
MaNaN1803
force-pushed
the
fix/11063-stackblitz-turbopack
branch
from
July 24, 2026 04:54
15aefa9 to
8f8dd75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11063. StackBlitz WebContainers currently do not support the native bindings required for Turbopack (the default in Next.js 15+). This updates all Next.js examples to use the --webpack flag in their dev scripts so the interactive sandboxes in the docs run without crashing.
Summary by CodeRabbit
next dev --webpackfor more consistent local behavior.