-
-
Notifications
You must be signed in to change notification settings - Fork 578
fix(react-form): complie error with webpack when react lower than v18 #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Change-Id: Ia4b18c0cf0d6a2c809923588c567f2cabbd08bde
🦋 Changeset detectedLatest commit: 4b819ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It's better to publish a pre-release to ensure it works for webpack project. But I don't know how to trigger the pre-release or test process. |
|
I'll trigger it for you. Let me know the results @lianghx-319 |
|
View your CI Pipeline Execution ↗ for commit 4b819ec
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
===========================================
- Coverage 90.35% 54.31% -36.05%
===========================================
Files 38 18 -20
Lines 1752 232 -1520
Branches 444 34 -410
===========================================
- Hits 1583 126 -1457
+ Misses 149 94 -55
+ Partials 20 12 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I will check it this weekend. |
Change-Id: Ia4b18c0cf0d6a2c809923588c567f2cabbd08bde
🎯 Changes
Patch needed to avoid bundlers trying to import non-existing export.
Original PR: iTwin/iTwinUI#1284
Read more: webpack/webpack#14814
✅ Checklist
pnpm test:pr.🚀 Release Impact