Skip to content

Update blender_thumbnailer.py to read Blender 5.x files - #1481

Open
050011-code wants to merge 3 commits into
TagStudioDev:mainfrom
050011-code:blend-thumbnail
Open

Update blender_thumbnailer.py to read Blender 5.x files#1481
050011-code wants to merge 3 commits into
TagStudioDev:mainfrom
050011-code:blend-thumbnail

Conversation

@050011-code

Copy link
Copy Markdown
Contributor

Summary

Updates blender_thumbnailer.py to read Blender 5.x files.

Refactor blender_thumbnailer.py to improve readability and maintainability. (Declaring this bit as AI made)

Handle file operations more safely.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@050011-code

050011-code commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

Thats on me for not remembering to fix the formating
Looks like I also massacred the attribution

@050011-code

050011-code commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

I'm sorry I was trying to make this pull request on my own fork!

There are still errors as its current state was not meant to be for the original repo

@050011-code
050011-code marked this pull request as draft August 16, 2026 12:07
@050011-code
050011-code marked this pull request as ready for review August 17, 2026 02:08
@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed TagStudio: Thumbs/Previews File thumbnails or previews labels Aug 17, 2026
@CyanVoxel CyanVoxel added this to the Alpha v9.6.4 milestone Aug 17, 2026
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 17, 2026
@CyanVoxel

Copy link
Copy Markdown
Member

(Declaring this bit as AI made)

Thank you for your willingness to contribute and fix this issue. Before I start making review comments on this, I'd like to cite our CONTRIBUTING.md's "Unacceptable Code" section:

Unacceptable Code
The following types of code will NOT be accepted to the project:

  • [...]
  • Code that you do not understand and/or cannot explain (i.e. "vibe coding")

If you're not able to explain why you made specific changes in this (preferably with sources from Blender where applicable) then I'm afraid I won't review this as per our contributing policy. If you do know what you're doing with these changes and are open to me (heavily) scrutinizing the AI-assisted changes, then I'll go ahead with an in-depth review. I wouldn't pester you over exact undocumented byte ranges as long as they work, but every other change I'd want explanations for.

Also, I just pulled this to actually give it a quick test, and it's not working with my Blender 5.x test file:
[info ] [ThumbRenderer][BLENDER][INFO] blender_5.blend Doesn't have an embedded thumbnail.
image

Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
Comment thread src/tagstudio/renderers/vendored/blender_thumbnailer.py Outdated
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Aug 17, 2026
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Aug 17, 2026
@CyanVoxel

Copy link
Copy Markdown
Member

Sorry for the conflict caused by #1483, a rebase to main should smooth that out

@CyanVoxel CyanVoxel added the Status: Changes Requested Changes are requested to this label Sep 3, 2026
@CyanVoxel

Copy link
Copy Markdown
Member

@050011-code Any updates on this?

@050011-code

Copy link
Copy Markdown
Contributor Author

Hey yes sorry, life has been busy so i haven't done anything on this, i should get free time this weekend to change it

@050011-code 050011-code closed this Sep 7, 2026
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in TagStudio Development Sep 7, 2026
@050011-code

Copy link
Copy Markdown
Contributor Author

I've never done this before, do I reopen here or will that not work anymore?

@CyanVoxel

Copy link
Copy Markdown
Member

@050011-code Yes you should be able to reopen here, I'm not sure if you closed this yourself or if something else triggered it to close, but rebasing shouldn't trigger a PR to close

@050011-code

Copy link
Copy Markdown
Contributor Author

I must have done something wrong, because it was automatic.
Hopefully reopening won't cause issues

@CyanVoxel CyanVoxel reopened this Sep 7, 2026
@050011-code

Copy link
Copy Markdown
Contributor Author

Haven't fully completed the changes yet, so ignore the checks for now

Refactor file handling to use context managers for better resource management.
@CyanVoxel CyanVoxel added Status: Review Needed A review of this is needed and removed Status: Changes Requested Changes are requested to this labels Sep 7, 2026
@CyanVoxel CyanVoxel moved this from ✅ Done to 🚧 In progress in TagStudio Development Sep 7, 2026
@CyanVoxel CyanVoxel moved this from 🚧 In progress to 👀 In review in TagStudio Development Sep 7, 2026
@CyanVoxel

Copy link
Copy Markdown
Member

Just to keep you up to date, we've updated the project to Python 3.14 which allows for the use of the zstandard library to use for the compressed Blender 5 files

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Doesn't require immediate attention TagStudio: Thumbs/Previews File thumbnails or previews Type: UI/UX User interface and/or user experience

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants