Skip to content

feat: expose SQL Server metadata comments - #24

Merged
debba merged 1 commit into
mainfrom
feat/issue-23-ms-description
Sep 16, 2026
Merged

debba merged 1 commit into
mainfrom
feat/issue-23-ms-description

Conversation

@debba

@debba debba commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add optional comment fields to table and column metadata while preserving legacy payload compatibility
  • read only MS_Description from sys.extended_properties with the correct object/column class, major_id, and minor_id scopes
  • safely convert sql_variant descriptions to Unicode text and propagate column comments through batch, schema snapshot, and AI metadata paths
  • cover apostrophes, Unicode, newlines, absent descriptions, exact property filtering, and host-model conformance

Testing

  • just fmt
  • just lint
  • just test
  • SQLSERVER_PLUGIN_BIN="$PWD/target/debug/sqlserver-plugin" SQLSERVER_TEST_HOST=127.0.0.1 SQLSERVER_TEST_PASSWORD='Str0ng!Passw0rd' cargo test --test live_db -- --test-threads=1
  • SQL Server 2022 metadata smoke check for get_tables, get_columns, get_all_columns_batch, get_schema_snapshot, and get_ai_schema_context with described, undescribed, and unrelated-property objects
  • git diff --check

Closes #23

@debba debba added the prerelease:beta Publish the next release on the beta prerelease channel label Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Version suggestion

Based on this PR's title (feat) and the prerelease:beta label:

Current 1.0.0-beta.1
Suggested next tag v1.0.0-beta.2

This is informational only — no tag or release is created automatically yet.

@debba
debba merged commit f729dc8 into main Sep 16, 2026
16 checks passed
@debba
debba deleted the feat/issue-23-ms-description branch September 16, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease:beta Publish the next release on the beta prerelease channel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose table and column comments in metadata responses

1 participant