feat(ios): add full-text search in data browser#657
Merged
Conversation
- Fix stale rows[index] crash in context menu/swipe closures (use captured row value) - Add CAST for MSSQL (NVARCHAR(MAX)) and ClickHouse (toString), default CAST(AS TEXT) - Filter BLOB/BYTEA/BINARY columns from search (produce garbage results) - Cancel previous search task before starting new one - Use ILIKE for PostgreSQL case-insensitive search - Add VoiceOver accessibility to RowCard and toolbar buttons - Keep bottom toolbar visible during active search/filter with empty results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAST(col AS CHAR/TEXT) LIKE '%term%'per column with dialect-aware escaping (MySQL CHAR, PostgreSQL TEXT, SQLite bare column)WHERE (search clauses) AND (filter clauses).searchablemodifier with on-submit trigger (no debounce)ContentUnavailableView.searchfor empty search resultsTest plan
%,_,') — verify escaping works