Repository navigation
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 03:19
# Conflicts: # apple/TableProMobile/TableProMobile/Drivers/MySQLDriver.swift # apple/TableProMobile/TableProMobile/Localizable.xcstrings # apple/TableProMobile/TableProMobile/Views/ConnectedView.swift
# Conflicts: # apple/TableProMobile/TableProMobile/Helpers/AppError.swift # apple/TableProMobile/TableProMobile/Localizable.xcstrings # apple/TableProMobile/TableProMobile/Platform/ConnectionSecretKind.swift # apple/TableProMobile/TableProMobile/ViewModels/ConnectionFormViewModel+Changes.swift # apple/TableProMobile/TableProMobile/ViewModels/ConnectionFormViewModel.swift # apple/TableProMobile/TableProMobile/Views/ConnectionFormView.swift # apple/TableProMobile/TableProMobileTests/ConnectionLibrary/ConnectionSecretsTests.swift
datlechin
disabled auto-merge
October 20, 2026 04:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AWSIAMTokenTarget. The Mac signs exactly as before.Test plan
Fail on main, pass here:
IAMPasswordMintTests,IAMSignInTests,ConnectionFormViewModelIAMTests,MySQLTokenSignInTests(a fake server that drops TLS and asks for cleartext never sees the token),IAMErrorClassifierTests,SignInOfferTests,PostgreSQLConnectionStringTests,RedisTLSOptionsMappingTests,DriverSSLConfigurationTests.ConnectionManagerSignInTests,RDSAuthTokenTests(fixed SigV4 vector, mixed-case hosts),AWSIAMTokenTargetTests,AWSSSOPortalTests,AWSSSOLoginTests.AWSIAMTokenSignerTests. The threeAWSIAMAuthTestssigner suites moved toRDSAuthTokenTestsunchanged.ConnectionSecretsTestschanges on purpose: it pins the new secret kinds and that the device-only item never syncs.Not in this PR
Docs: TableProApp/docs#59
Fixes #3638