Repository navigation
feat(ios): view and edit JSON values on the row screen - #3686
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 03:01
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings # apple/TableProMobile/TableProMobile/ViewModels/DataBrowserViewModel.swift # apple/TableProMobile/TableProMobile/ViewModels/RowDetailViewModel.swift # apple/TableProMobile/TableProMobile/Views/DataBrowserView.swift # apple/TableProMobile/TableProMobile/Views/RowDetailView.swift # apple/TableProMobile/TableProMobileTests/DataBrowserViewModelTests.swift
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonorjsonbfield on the row screen shows indented, with View as JSON: Text and Tree modes, Copy, and Copy Value, Copy Key and Copy Key Path on tree rows. A text column holding a JSON object or array gets the same viewer.prefix... (N KB)or[BLOB N]placeholder. The table browser loads values over 4 KB in full first. A binary value, or a cut value in query results, shows Cannot Export.SET NOCOUNT ON.''.Test plan
ColumnInfoTypeFamilyTests,JSONPrettyPrinterTests,JSONOutlineTests(TableProCore),JSONValidationTests,LiteralInputTraitsTests, and the new cases inRowDetailViewModelTests,DataBrowserViewModelTests,ClipboardExporterFidelityTests.loadedLongTextSavesItsEditnow returns the saved text from its loader, since Save reads the value back.JSONcolumn: row screen, Text and Tree, Edit JSON with a trailing comma showsLine 18, column 1: Unexpected character.with Done dimmed.Not in this PR
01and\q: a Mac fix of its own.Fixes #3637