Repository navigation
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 02:46
# Conflicts: # apple/TableProMobile/TableProMobile/Views/ConnectionListView.swift
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings
# Conflicts: # apple/TableProMobile/TableProMobile/Localizable.xcstrings # apple/TableProMobile/TableProMobileTests/Onboarding/AppStateFixture.swift
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLFavoriteandSQLFavoriteFolderwith the Mac's rules: one keyword per connection, the older query keeps a contested keyword, 900 KB limit. An existing install refetches once, since its change token already passed these records. No CloudKit schema change: both types are already in production..tableproimport reviews and imports saved queries as the Mac does, and the result alert counts them. Export gets Include Saved Queries and Also include global saved queries.Test plan
SyncRecordMapperSavedQueryTests,SavedQueryKeywordResolverTests,SavedQueryOutlineTests,SavedQueryImportPlacementTests,SavedQueryCodingTests,SavedQueryLedgerTests(keyword availability). iOSSavedQueryLibraryTests,SavedQueryRemoteMergeTests,SyncedWriteFailureTests,AppStateSyncWiringTests,SavedQueryDraftTests,MobileImportOutcomeMessageTests, new cases inIOSSyncCoordinatorTestsandDeletedConnectionPurgeTests. MacSyncCategoryRefetchTests.IOSConnectionImportServiceTests(savedQueriesAreIgnoredis nowsavedQueriesImport; a duplicate offers Keep Existing when the file holds its queries),IOSConnectionExportServiceTests(saved-query keys left out only when there are none),SyncFieldParityTests(both saved-query field enums are now shared record types),IOSSyncCoordinatorTests(fixture apply callbacks returnBool)..tableprowith three saved queries, saved one from the editor, made a folder and moved it there, opened it in the editor, opened the export sheet.Fixes #3634