Repository navigation
fix(plugins): stop creating a stray Application%20Support folder for the registry cache - #3677
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLCache(memoryCapacity:diskCapacity:diskPath:). On macOS 15 and earlier thedirectory:initializer opens the cache at the percent-encoded path (FB9117600), which created~/Library/Application%20Support/TablePro/Registry/URLCache.RegistryStorageSweep, run after launch in production, removes:.DS_Storecounts as empty). It never touches an ancestor of the real path and does nothing when the path has nothing to encode.TablePro/Registry/registry-manifest.json, which 0.81 wrote and feat(plugins): read the v3 plugin manifest from updates.tablepro.app #3503 stopped reading.~/Library/Caches/<bundle id>/registry-manifest.json, the pre-0.55 location whose migration feat(plugins): read the v3 plugin manifest from updates.tablepro.app #3503 dropped.com.TablePro.registryLastFetch,com.TablePro.customRegistryURL, and the pre-0.40 keys).apple/scripts/probes/check-urlcache-directory-path.shreports where each initializer putsCache.db.Test plan
RegistryStorageSweepTests: the cache under a root with a space opens at the file-system path; the sweep removes the misplaced tree and empty encoded parents, keeps a parent holding other files, leaves a cache whose path has nothing to encode, and removes the retired manifests and keys while keeping the others.Fixes #3676