Skip to content

fix(settings): let the inspector glass show behind its field list - #3590

Merged
datlechin merged 2 commits into
mainfrom
fix/theme-inspector-pane
Oct 19, 2026
Merged

datlechin merged 2 commits into
mainfrom
fix/theme-inspector-pane

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

Under a custom theme the inspector's field area was a warm gray slab inside an otherwise themed window. The inspector frame is AppKit glass that already takes the theme's window color, matching the sidebar. The field list is a SwiftUI List, which puts its own content-background material behind its rows, and that material never follows the window color. #3395 removed the hidden list background that used to sit there.

Change

  • The inspector field list and the agent's proposed statements list hide their own background on macOS 26 and later, so the inspector glass shows through and the whole pane matches the sidebar. This is the new design's guidance for effect views inside glass split items. Before macOS 26 nothing changes.
  • Applies to the main window and the Data File window.
  • Under the default themes the field area now shows the inspector glass too (light: white becomes the glass gray).

Verified

SplitItemGlassBackgroundTests checks that the field list and the statements list draw no content-background material where split items are glass, and that a plain list still does without the modifier. On screen, Tokyo Night: field area (57,54,53) before, (49,48,58) after, equal to the inspector header and the sidebar.

Screenshots

Tokyo Night inspector, before and after:

Before dark After dark

Default light inspector, before and after:

Before light After light

Whole window, Tokyo Night, after:

After window

Not in this PR

  • SwiftUI Tables in Users & Roles and Compare sit in the detail column, not a glass item, and stay chrome (theme.md).

@datlechin
datlechin merged commit 6fc948c into main Oct 19, 2026
17 checks passed
@datlechin
datlechin deleted the fix/theme-inspector-pane branch October 19, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant