Repository navigation
fix(settings): let the inspector glass show behind its field list - #3590
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under a custom theme the inspector's field area was a warm gray slab inside an otherwise themed window. The inspector frame is AppKit glass that already takes the theme's window color, matching the sidebar. The field list is a SwiftUI
List, which puts its own content-background material behind its rows, and that material never follows the window color. #3395 removed the hidden list background that used to sit there.Change
Verified
SplitItemGlassBackgroundTestschecks that the field list and the statements list draw no content-background material where split items are glass, and that a plain list still does without the modifier. On screen, Tokyo Night: field area (57,54,53) before, (49,48,58) after, equal to the inspector header and the sidebar.Screenshots
Tokyo Night inspector, before and after:
Default light inspector, before and after:
Whole window, Tokyo Night, after:
Not in this PR
Tables in Users & Roles and Compare sit in the detail column, not a glass item, and stay chrome (theme.md).