Repository navigation
Conversation
Record auto-increment column names during snapshot export and pass them to the existing sequence reset helper when restoring rows. Skip sequence resets for tables without an auto-increment column. This avoids repeated PostgreSQL catalog queries and restores generated IDs correctly for quoted mixed-case columns. Add functional coverage for ordinary and custom ID columns, repeated restores and non-sequence tables. A local PostgreSQL 17 benchmark of SlugLinkGeneratorTest drops from 46.93 s to 42.37 s with the same 194 tests and 202 assertions. The number of sequence catalog lookups drops from 2,123 to zero. WIP: prepared for CI validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record auto-increment column names during snapshot export and pass them to the existing sequence reset helper when restoring rows. Skip sequence resets for tables without an auto-increment column.
This avoids repeated PostgreSQL catalog queries and restores generated IDs correctly for quoted mixed-case columns. Add functional coverage for ordinary and custom ID columns, repeated restores and non-sequence tables.
A local PostgreSQL 17 benchmark of SlugLinkGeneratorTest drops from 46.93 s to 42.37 s with the same 194 tests and 202 assertions. The number of sequence catalog lookups drops from 2,123 to zero.