Conversation
tolauwae
force-pushed
the
fix/maarten
branch
from
September 4, 2026 07:57
81d1b9f to
dfeacf6
Compare
tolauwae
force-pushed
the
fix/maarten
branch
4 times, most recently
from
September 9, 2026 13:15
def6411 to
3858872
Compare
tolauwae
marked this pull request as ready for review
September 11, 2026 14:05
Member
Author
|
@MaartenS11 I might have missed some stuff still, but I think the refactor is ready. I mostly concerned I might have misinterpreted some snapshot or checkpoint code. Can you check if MIO still works? I will make some docs of the new protobuf interface to make it easier to implement. but should be pretty straightforward on the kotlin side with the Also: snapshot replaces dump and inspect, and uses a bitmask for selection the sections. Default it gives everything. |
tolauwae
removed this pull request from stack #415
September 24, 2026 09:45
tolauwae
added this pull request to stack #418
September 24, 2026 09:50
Fix build Remove deprecated dump and inspect code
tolauwae
force-pushed
the
fix/maarten
branch
from
September 24, 2026 09:54
6485717 to
96c35cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for #406.
This PR completes the protobuf refactor (part of the PR stack #415). Overview of changes to the debug ABI are summarized in #406.
Trying it Out
Easiest to try out with the syrup console on the
tools/syrup(#407):