Repository navigation
Add hero images to TV demo carousel - #146
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each slide in the TV demo's home carousel now shows a hero image behind the stream's title, instead of a plain colored gradient.
Streamgains@DrawableRes image: Int. The images are inapp/src/main/res/drawable-nodpi/stream_*.jpg, at most 1920 px wide.StreamSlidedraws the image withContentScale.Crop, then aSlideScrim(a dark gradient from the left and from the bottom) so the white text stays readable.app/README.mddescribes the demo app and credits the images.docs/assets/tv-demo-home.jpg(a JPEG, because the photos make a PNG much larger).Link to Devin session: https://dolby.devinenterprise.com/sessions/c92e3de4d3b0416384ebe04af7ef9499
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/c92e3de4d3b0416384ebe04af7ef9499?variant=devin
Requested by: @MattiasBuelens