Bulk multibyte

[SuuperW]

To enable bulk poke/peek access for 16 and 32 bit values, I have given MemoryDomain , IMemoryApi, and MemoryLuaLibrary some new functions.

Check if completed:

• I have run any relevant test suites
• I, the commit author, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

[YoshiRulz]

On top of cleaning up IMemoryApi, I would also like to clean up Range<T> (#3965) before adding new uses to MemoryDomain.

[YoshiRulz]

Write*Range signatures are fine for Span, but then why do Read*Range allocate and return arrays?
See also #3472.
Not that you need these anyway, since the caller can just MemoryMarshal.Cast to/from byte.

[SuuperW]

I think it was just a lot simpler to do it that way, and the byte one returns an array IIRC so I was following that.
I knew you were wanting to update some of this stuff anyway, so I didn't think it very important.

[SuuperW]

Update on this: The new read methods return IReadOnlyList, so as to match the existing ReadByteRange method. I considered changing them all to accept a Span instead but that's too much work to do before release.
The existing WriteByteRange method was changed to accept a Span though, since this is good and easy to do and makes it match the new ones.

[SuuperW]

Regarding all of your comments about being able to just convert between bulk byte and bulk int reads: No. The only reason I made this is to support #4555. The core MUST know what size we are reading, and the various sized reads cannot simply be re-interpreted as another.

[vadosnaprimer]

Conflicts appeared, but also it's unclear from the discussion if there's anything else that has to change still.

[SuuperW]

I was going to wait for Yoshi to finish #3965 but I can go ahead and fix some stuff here in a few days.

[vadosnaprimer]

I was going to wait for Yoshi to finish #3965

That one looks like it will require 20 more years to get done abandoned forever.

[SuuperW]

Fixed bugs and added tests for the bulk API methods. That code is absolutely horrible, matching the existing bulk byte methods.

IMemoryApi.WriteByteRange was changed from accepting a IReadOnlyList<byte> to Span<byte> which is technically an API change but byte[] works for both without an explicit cast. That lets it use the new underlying MemoryDomain.BulkPokeByte, and it also what the new bulk poke API methods do. If we need the version that accepts a list, I can make overloads for them.