Fix Critical Round-Trip Conversion Issues#2
Open
kamil-kaszuba wants to merge 1 commit intoSzymonHalucha:mainfrom
Open
Fix Critical Round-Trip Conversion Issues#2kamil-kaszuba wants to merge 1 commit intoSzymonHalucha:mainfrom
kamil-kaszuba wants to merge 1 commit intoSzymonHalucha:mainfrom
Conversation
Author
|
@SzymonHalucha will you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix Critical Round-Trip Conversion Issues
📋 Summary
This PR fixes critical bugs in string case conversion methods that were causing round-trip conversions to fail, along with a modernized test suite migration to xUnit.
🚨 Critical Bug Fixed
Round-Trip Conversion Failures
Issue: Converting between different string cases and back to the original format was producing incorrect results.
Example of the main failure:
Root Cause & Fix:
Problem: Word boundary detection failed when transitioning from special characters (dashes/underscores) back to letters, breaking the separator insertion logic.
Solution: Enhanced separator logic to detect transitions from special characters:
✅ Impact
🧪 Test Suite Modernization
Side improvement: Migrated from MSTest to xUnit with data-driven testing
Type: 🐛 Critical Bug Fix
Breaking Changes: None
Validates: All round-trip conversions now preserve original values