Revert drill 3: restore AlitaBot - #312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #309. Drill 3 complete.
The six fixes from #307 are validated
notify-failure+srefireddormant_exempt: false@mThe SRE agent also diagnosed a disguised bug correctly — no drill token in the logs, and it still found
Seq.headon an empty sequence atProgram.fs:60and proposedSeq.tryHead. Filed as #311.The remaining defect: severity is defined by pod health, not service health
The agent concluded:
AlitaBot was answering nobody. The owner sent two messages during the incident and received no reply; both are in Loki as
NullReferenceExceptionwith TraceIds48c893b3…ande0d504ae….This is not an agent error — it followed
sre.mdcorrectly. The severity table defines P1 as "No pods serving traffic — all replicas unhealthy, 5xx rate is high, app completely unreachable." For these bots:/botwebhook returns 200 regardless of internal exceptions, to stop Telegram retry storms/healthzreturns OKSo all three P1 criteria are structurally unreachable, no matter how broken the bot is. The taxonomy cannot express "process healthy, service dead" — which is the dominant real failure mode here.
Its suggested mitigation, "restart the pod to clear the current error loop", also wouldn't have helped: the fault is deterministic and would recur immediately.
Follow-up: rewrite
sre.md's severity table around service-level signals — Loki error rate on the update-handling path, and successful update handling — rather than pod health and 5xx. Tracked separately.🤖 Generated with Claude Code
https://claude.ai/code/session_01P41roCWN5Fec7m69sSaunU