Enable SRE coverage for AlitaBot#300
Merged
Merged
Conversation
Found by the 2026-07-27 SRE drill: a deliberate startup failure was deployed to AlitaBot prod, verify-deploy.sh correctly detected it and classified it `app`, and then nothing happened — `notify-failure` and `sre` both skipped, because alita-deploy.yml set `sre-enabled: false`. AlitaBot was therefore the ONE bot in the fleet with no SRE coverage, while `.github/prompts/sre.md` simultaneously stated "every bot in this monorepo opts into SRE coverage by default, including future ones" — documentation asserting the opposite of configuration, which is exactly the kind of gap that reads as covered until you test it. The original `false` was a considered choice (comment retained): a brand-new bot's first deploys deserve a human reading verify-deploy output directly rather than an agent with no track record. That reasoning has expired — AlitaBot has run in prod since 2026-07-22. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P41roCWN5Fec7m69sSaunU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the SRE drill
A deliberate startup failure was deployed to AlitaBot prod (run 30255492040).
verify-deploy.shworked perfectly:Correct detection, correct
appclassification (validating #279 against a real crashloop). Then nothing happened —notify-failure: skipped,sre: skipped.Cause:
alita-deploy.yml:45setsre-enabled: false, so AlitaBot was the one bot in the fleet with no SRE coverage — while.github/prompts/sre.mdstates "every bot in this monorepo opts into SRE coverage by default, including future ones." Documentation asserting the opposite of configuration.Why flip it now
The original
falsewas a considered choice, and its comment is retained: a brand-new bot's first deploys deserve a human readingverify-deploy.shoutput directly rather than an agent with no track record. That reasoning has expired — AlitaBot has run in prod since 2026-07-22, and the point of the drill is to build exactly that track record on the safest bot in the fleet.Note AlitaBot remains excluded from the
productrole (.github/bots.yml,roles: [monitor, sre]) — it has 13 chat messages ever, so a product agent there would produce filler. That exclusion is intentional and unrelated.🤖 Generated with Claude Code
https://claude.ai/code/session_01P41roCWN5Fec7m69sSaunU