Skip to content

ST6RI-931 Implied owner of an implicit binding connector may be shown incorrectly #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seidewitz merged 2 commits into from
Jun 18, 2026
Merged

ST6RI-931 Implied owner of an implicit binding connector may be shown incorrectly #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d1d96
ST6RI-931 Made implied binding connectors owned by OwningMembership.
seidewitz Jun 14, 2026
9fb8594
ST6RI-931 Revised KerMLOutlineProvider so implied relationships are last
seidewitz Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions org.omg.kerml.xtext.ui/src/org/omg/kerml/xtext/ui/outline/KerMLOutlineTreeProvider.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,16 +513,15 @@ class KerMLOutlineTreeProvider extends DefaultOutlineTreeProvider {
}

def void _createChildren(IOutlineNode parentNode, Type type) {
//ImplicitFieldAdapter.getOrCreateAdapter(type).
createImplicitGeneralizationNodes(parentNode, type)
_createChildren(parentNode, type as Namespace)
createImplicitBindingConnectorNodes(parentNode, type)
createImplicitSpecializationNodes(parentNode, type)
if (type instanceof Feature) {
createImplicitTypeFeaturingNodes(parentNode, type)
}
_createChildren(parentNode, type as Namespace)
createImplicitBindingConnectorNodes(parentNode, type)
}

def createImplicitGeneralizationNodes(IOutlineNode parentNode, Type type) {
def createImplicitSpecializationNodes(IOutlineNode parentNode, Type type) {
TypeUtil.forEachImplicitGeneralTypeOf(type, [eClass, generalType |
/*
* TODO here image dispatcher should be called with a type that
Expand Down Expand Up @@ -597,8 +596,6 @@ class KerMLOutlineTreeProvider extends DefaultOutlineTreeProvider {
}

def void _createChildren(IOutlineNode parentNode, OperatorExpression expression) {
createImplicitGeneralizationNodes(parentNode, expression)
createImplicitTypeFeaturingNodes(parentNode, expression)
for (Relationship relationship : expression.ownedRelationship) {
createNode(parentNode, relationship,
_image(relationship),
Expand All @@ -608,6 +605,8 @@ class KerMLOutlineTreeProvider extends DefaultOutlineTreeProvider {
);
}
createImplicitBindingConnectorNodes(parentNode, expression)
createImplicitSpecializationNodes(parentNode, expression)
createImplicitTypeFeaturingNodes(parentNode, expression)
}

override _createNode(DocumentRootNode parentNode, EObject modelElement) {
Expand Down
4 changes: 2 additions & 2 deletions org.omg.sysml.logic/src/main/java/org/omg/sysml/adapter/TypeAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,14 @@ public void forEachImplicitBindingConnector(Consumer<BindingConnector> consumer)

/**
* Executes the given consumer function with all implicit binding connectors and
* their corresponding membership type (Membership or FeatureMembership)
* their corresponding membership type (OwningMembership or FeatureMembership)
*/
public void forEachImplicitBindingConnector(BiConsumer<BindingConnector, EClass> consumer) {
for (BindingConnector connector : implicitFeatureBindingConnectors) {
consumer.accept(connector, SysMLPackage.Literals.FEATURE_MEMBERSHIP);
}
for (BindingConnector connector : implicitMemberBindingConnectors) {
consumer.accept(connector, SysMLPackage.Literals.MEMBERSHIP);
consumer.accept(connector, SysMLPackage.Literals.OWNING_MEMBERSHIP);
}
}

Expand Down
Loading