Skip to content

Move State out of AcitivityIndicator #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FichteFoll merged 1 commit into from
Feb 21, 2026
Merged

Move State out of AcitivityIndicator #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions sublime_lib/activity_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ def clear(self) -> None:
self.view.erase_status(self.key)


class State(IntEnum):
STOPPED = 0
STOPPING = 1
RUNNING = 2


class ActivityIndicator:
"""
An animated text-based indicator to show that some activity is in progress.
Expand All @@ -61,11 +67,6 @@ class ActivityIndicator:
.. versionadded:: 1.4
"""

class State(IntEnum):
STOPPED = 0
STOPPING = 1
RUNNING = 2

frames: str | list[str] = "⣷⣯⣟⡿⢿⣻⣽⣾"
interval: int = 100

Expand All @@ -84,7 +85,7 @@ def __init__(
self._target = target

self._lock: Lock = Lock()
self._state: int = self.State.STOPPED
self._state: State = State.STOPPED
self._ticks: int = 0
self._tick_ref = weak_method(self._tick)

Expand All @@ -111,14 +112,14 @@ def start(self) -> None:
:raise ValueError: if the indicator is already running.
"""
with self._lock:
if self._state == self.State.RUNNING:
if self._state == State.RUNNING:
raise ValueError("Activity indicator is already running!")
elif self._state == self.State.STOPPING:
self._state = self.State.RUNNING
elif self._state == State.STOPPING:
self._state = State.RUNNING
else:
self.update()
sublime.set_timeout(self._tick_ref, self.interval)
self._state = self.State.RUNNING
self._state = State.RUNNING

def stop(self) -> None:
"""
Expand All @@ -127,16 +128,16 @@ def stop(self) -> None:
If the indicator is not running, do nothing.
"""
with self._lock:
if self._state != self.State.STOPPED:
self._state = self.State.STOPPING
if self._state != State.STOPPED:
self._state = State.STOPPING

def _tick(self) -> None:
with self._lock:
if self._state == self.State.RUNNING:
if self._state == State.RUNNING:
self.tick()
sublime.set_timeout(self._tick_ref, self.interval)
return
self._state = self.State.STOPPED
self._state = State.STOPPED
self._target.clear()

def tick(self) -> None:
Expand Down
Loading