Repository navigation
adding 'TabStack.sublime-settings' and "preview_file" setting #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+97
−2
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| [ | ||
| { | ||
| "caption": "Preferences", | ||
| "mnemonic": "n", | ||
| "id": "preferences", | ||
| "children": | ||
| [ | ||
| { | ||
| "caption": "Package Settings", | ||
| "mnemonic": "P", | ||
| "id": "package-settings", | ||
| "children": | ||
| [ | ||
| { | ||
| "caption": "TabStack", | ||
| "children": | ||
| [ | ||
| { | ||
| "command": "open_file", | ||
| "args": {"file": "${packages}/TabStack/TabStack.sublime-settings"}, | ||
| "caption": "Settings – Default" | ||
| }, | ||
| { | ||
| "command": "open_file", | ||
| "args": {"file": "${packages}/User/TabStack.sublime-settings"}, | ||
| "caption": "Settings – User" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| // Show the highlighted file while the list is open. | ||
| // When false, the file changes only after the list closes. | ||
| "preview_file": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import sublime | ||
|
|
||
| SETTINGS_FILE = "TabStack.sublime-settings" | ||
| _settings = sublime.load_settings(SETTINGS_FILE) | ||
|
|
||
|
|
||
| def save_settings() -> None: | ||
| sublime.save_settings(SETTINGS_FILE) | ||
|
|
||
|
|
||
| def preview_file() -> bool: | ||
| """Whether the highlighted list entry is shown before the list closes.""" | ||
| return _bool_setting("preview_file", default=True) | ||
|
|
||
|
|
||
| def _bool_setting(key: str, *, default: bool) -> bool: | ||
| value = _settings.get(key, default) | ||
| return value if isinstance(value, bool) else default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether we really need these "Settings - Default", but other packages contain that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would want to use the
edit_settingscommand like #12 does instead of providing two separate commands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I don't understand how to adapt the
edit_settings.Should I just revert my version of "Main.sublime-menu" since it's already present in your PR?
Or should I copy-paste your implementation and add something there? If so, what should I add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about it. It was just meant as an FYI since I won't be merging this PR either way since it has too many conflicts and the one thing still left, the
preview_filesetting, I would rather do on my own.