Modernize repo and make sure it works with ST4#9
Draft
Frizlab wants to merge 70 commits intoSublimeText:masterfrom
Draft
Modernize repo and make sure it works with ST4#9Frizlab wants to merge 70 commits intoSublimeText:masterfrom
Frizlab wants to merge 70 commits intoSublimeText:masterfrom
Conversation
AFAICT the tests **must** be run in Sublime Using <https://github.com/SublimeText/UnitTesting> probably helps (and it can also run the tests in GitHub Actions).
|
If you want to check ST3 compat, UnitTesting has a GH Action that can do it for you. There's probably not any divergence between platforms, so ST3, ST4 on Ubuntu is probably enough. If you have CI minutes to burn. 😅 |
Author
|
Yes I noticed the UnitTesting repo has a GitHub Actions for testing in the CI and thought about setting that up. Thanks for the review! I have not finalized everything yet, the PR is still a draft for now (I have to implement the format change, cleanup the tests even more, etc.) I will do the changes you proposed/requested before marking the PR ready. |
Apparently everything works with an empty __init__…
Make a comment more precise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That being said: