Repository navigation
data: add four national libraries and seven international airports - #344
Open
propcgamer20-png wants to merge 1 commit into
Open
propcgamer20-png wants to merge 1 commit into
propcgamer20-png wants to merge 1 commit into
Conversation
Libraries: Library of Congress, National Library of Ireland, Biblioteca Nacional de Chile, Bibliotheca Alexandrina. Airports: Suvarnabhumi, Narita, Haneda, Hamad, Hong Kong, Noi Bai, Kotoka.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Hello @propcgamer20-png Thanks for opening up a PR. We value and appreciate your contribution to StudentSuite. We will be reviewing your PR shortly. While we do that, could you please take out the time to star this repo and follow our organisation? This helps us push your tool to more students and helps us get more amazing contributors just like you. Thanks again! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 11 places in 10 countries (US, IE, CL, EG, TH, JP, QA, HK, VN, GH), none of which were in the dataset.
Libraries (addresses read from each library's own site): Library of Congress (10 First Street SE), National Library of Ireland (7-8 Kildare Street, D02 P638), Biblioteca Nacional de Chile (Av. Libertador Bernardo O'Higgins 651), Bibliotheca Alexandrina (Chatby, Alexandria).
Airports (official sites load and name the airport): Suvarnabhumi, Narita, Haneda, Hamad, Hong Kong International, Noi Bai, Kotoka.
Coordinates are from OpenStreetMap (Nominatim);
gmaps_linkuses the repo's?q=lat,lngform. Ids follow the existing convention (IATA prefix for airports). Existing records are untouched.npm run validate:placespasses (6 files, 3 pre-existing warnings); no em dashes.