docs: fix stale Base chain references (Arbitrum)#3
Open
koko1123 wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated README.md examples to use Arbitrum Sepolia instead of Base Sepolia, including the RPC URL values and the example chain ID. ChangesREADME network reference update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 23: The quickstart example is out of sync with the chain-id contract
because PerpCityContext still defaults to 84532 while the setup path shown here
uses Arbitrum Sepolia; update the quickstart to pass the correct chain_id
override (421614) alongside rpc_url, or adjust the PerpCityContext default and
validate_chain_id() behavior to match this documented network. Use the
PerpCityContext initialization and validate_chain_id() symbols to locate the
contract between the SDK and the README example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only: the protocol runs on Arbitrum, not Base. No code changes.
Corrections
base-sepolia.g.alchemy.com->arb-sepolia.g.alchemy.comchain_id=84532(Base Sepolia) ->chain_id=421614(Arbitrum Sepolia)Follow-ups (code still references Base, intentionally not touched in this docs-only PR)
src/perpcity_sdk/context.py:26:DEFAULT_CHAIN_ID = 84532 # Base Sepolia-> should become 421614 (Arbitrum Sepolia)src/perpcity_sdk/utils/rpc.py:11-13: error message suggests Base Sepolia RPC URLs (base-sepolia.g.alchemy.com,base-sepolia.infura.io,sepolia.base.org)Summary by CodeRabbit
chain_idargument) to match the new test network.