Skip to content

radio-field.php and product-radio.php have the same wrap+for double-association pattern as checkbox/GDPR #3475

Description

@vivi-the-going-merry

Background

formidable-forms#3465 fixed the Safari VoiceOver double-announcement bug on checkbox and GDPR fields (Strategy11/formidable-pro#6750) by dropping the redundant for attribute from a <label> that already wraps its <input>.

franky-review's approval note on #3465 confirmed classes/views/frm-fields/front-end/radio-field.php and classes/views/frm-fields/front-end/product-radio.php have the identical pattern on their own option labels — both build the label's for and the input's id from the same $html_id . '-' . $opt_key expression, same shape as the two files #3465 fixed.

The linked issue (formidable-pro#6750) only reported checkbox/GDPR, so #3465 stayed scoped to those two files. Filing this so the radio/product-radio instances don't get lost.

Suggested fix

Same mechanical fix as #3465: drop the redundant for attribute from each option <label> in both files, since the wrap alone already associates label and input.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions