Keep capture in private overlays and harden History sharing - #21
Merged
StoneHub merged 2 commits intoSep 5, 2026
Merged
Conversation
StoneHub
marked this pull request as ready for review
September 5, 2026 12:54
StoneHub
added a commit
that referenced
this pull request
Sep 5, 2026
* feat: refocus v1.8 on browser capture core * fix: close agent handoff validity gaps * Add the Electron Inspector adapter (#14) * feat: add Electron Inspector package Closes #13 * fix: clarify Electron History handoff * fix: preserve Electron feature semantics * fix: scrub legacy Electron History text * Add one-line Electron inspector registration * Prepare free MIT Electron package (#15) * Add optional Stripe support link (#17) * Rename Electron package for npm organization (#18) Co-authored-by: StoneHub <14373165+StoneHub@users.noreply.github.com> * Keep capture in private overlays and harden History sharing (#21) * Harden private overlay capture and selected feedback exports * Treat PDF validation fixtures as binary artifacts --------- Co-authored-by: StoneHub <14373165+StoneHub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element feedback now opens in a private overlay and preserves the source tab. Region editing uses the same presentation where injection is available, with a capture popup window for protected surfaces. History exports now require a selection and a preview; deleting filtered captures preserves hidden records.
This follow-up to #12 also restricts History and editor message access, removes captured DOM context from redacted records, strips source URL secrets on export, preserves drafts across save failures, checks source-tab stability during screenshots, fixes first-crop initialization and the Electron menu callback, and updates vulnerable transitive dependencies. CI checks advisories and creates draft releases.
Validation: 48 tests plus release assertions, release checks, zero known production dependency vulnerabilities in this candidate, verified 20-file ZIP, and clean diff checks. Isolated headless Chromium exercised Element and Region overlays, rendered PDF capture, redaction, selected exports, filtered deletion, cancellation, and draft preservation.
The headless copy used a test-only host grant to avoid driving the owner's desktop. Shipping permissions remain storage, activeTab, and scripting. Exact-manifest activation, local-file PDF permission behavior, Store screenshots, and an installed-extension-to-MCP-client handoff remain release checks. Full evidence and limits are in
docs/hardening-validation.md.Base:
codex/browser-capture-core(#12). This does not publish or merge the candidate.