Use <cmath> for lgamma - #419
Open
MichaelChirico wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids any boost headaches and should be equivalent (up to machine precision).
Written by Gemini while pursuing a crash. If boost is involved in the crash, it's a bit uglier to debug vs. if
std::lgammais used. It's also consistent with nearby usages ofstd::log().OTOH, AIUI
boost::math::lgammais slightly more accurate, so perhaps the choice was intentional. E.g. Gemini offers the following:Where Boost is slightly more accurate:
Peak ULP Error:
boost::math::lgamma: Maintains a peak error strictly bounded understd::lgamma(glibc / libm): Peak error typically hovers aroundNear Roots ($x \approx 1$ and $x \approx 2$ ):
log1pvariants) to preserve 15–16 significant digits across the zero-crossings.Does it matter for
stochtree?stochtree,lgamma(a)is called on shape parameters (